-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove leftover FreeBSD related code and documentation #7739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm. This is a good question. In the past, our theory had been that someone might revisit this, so we should leave the code in place. But, it's not wrong to re-evaluate it, and simpler code has some advantages. I am ambivalent.
I vote to remove it for now; the code will always exists in the git history for reference. There hasn't been a direct interest in it (and with direct I mean a contributor with the interest, ability and time to support it), and we are not updating it/keeping it working since the start of 4.x, so it's just dead code. Additionally, we don't have the infra for the CI to run tests, and it would be an additional maintenance burden for whoever finds itself having to update a library, and reconfigure it on all the platforms and architectures. |
In other projects, we've generally followed the idea that it will exist in git history so we can revive it there, where necessary, as Stefano is saying. Deleting code is a joy! That said, at the very least, we would still want to get rid of the .table files right? Happy to pare this down in some way, wherever you guys decide. But I figure I would start here by submitting the maximalist approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's okay?
Grr yes will fix
Mo Zhu
… On Aug 25, 2022, at 9:34 AM, seph ***@***.***> wrote:
@directionless commented on this pull request.
In specs/CMakeLists.txt:
> @@ -153,11 +153,9 @@ function(generateNativeTables)
"darwin/xprotect_entries.table:macos"
"darwin/xprotect_meta.table:macos"
"darwin/xprotect_reports.table:macos"
- "linux/selinux_events.table:linux"
This look accidental, bad merge maybe?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Removing freebsd from: