Support rollbacks of osquery when new versions introduce new column families #7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the failing tests known to be flaky? Or should I try to troubleshoot what's going on? |
There's a flaky test: #7433. I'll re-run the failed jobs. |
|
@Smjert @mike-myers-tob Hi folks. Could you re-trigger a CI check? (to check if I need to fix anything else) |
|
@lucasmrod closing and reopening PR to trigger CI |
|
@Smjert How's it look to you? |
Smjert
requested changes
Dec 10, 2022
There was a problem hiding this comment.
@lucasmrod Thanks for trying this idea!
It definitely works, but I would restructure a little the code, if possible (see below).
9599820
to
37ba2fa
Compare
|
@Smjert Super appreciate the feedback! The review comments have been addressed. |
Smjert
approved these changes
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is implementing what @Smjert proposed here: #7675 (comment)
I tested it with a database written by a branch that introduced a new column family (#7675).