Always use BIGINT macro for 'long long' data #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can enforce the schema with a small heuristic similar to https://github.com/osquery/osquery/blob/master/tools/codegen/gentable.py#L415 My thought was to look for columns named |
Table gen spec file is a bit of internal magic I am not familiar with, but that looks like a relatively simple change, someone just has to generalize that check already being done currently for |
theopolis
approved these changes
Mar 11, 2021
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…0 to master * commit '943935789dbfb03b55db1471ed1595e1fd4ffe23': (119 commits) seccomp migrations Add 4.7.0 CHANGELOG (osquery#6985) ATC fails because journal_mode pragma is blocked by sqlite authorizer (osquery#6999) Always use BIGINT macro for 'long long' data (osquery#6986) chrome_extensions: Refactor the table, add tests (osquery#6780) Remove extraneous lenses directory for augues on macOS (osquery#6998) Update the info about macOS CI (osquery#6988) Make Group ID columns consistent across Windows tables (osquery#6987) Fix mem leak regression with Windows' sids API (osquery#6984) Fix error in process_open_files around stoi vs stoul (osquery#6983) Remove hash and yara table from fuzz harnesses (osquery#6972) Augeas Table: Don't autoload system lenses (osquery#6980) Augeas Table: Fix output bug (osquery#6981) Add concat and concat_ws functions (osquery#6927) Copy JSON objects to avoid MemoryPool buildup (osquery#6957) Fix CODEOWNERS syntax to allow committers and TSC (osquery#6975) augeas: Clear aug pointer on error (osquery#6973) Adds support for the computer field in Windows Eventlogs (osquery#6952) Add Shellbags table (osquery#6949) Implementation of VM metadata table for Yandex.Cloud (osquery#6961) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #6897 this is basically the same deal: always use the
BIGINTmacro rather than theINTEGERmacro when dealing withlong longvalues, or they might generate warnings and not report data, the same as explained in the last PR.