Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable incremental linking to reduce build size on Windows #6898

Merged

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Jan 12, 2021

A previous PR removed the unused /LTCG linker flag,
which was also disabling incremental linking,
permitting the build to stay under a certain size.
Now that the incremental linking is enabled again,
the size of a full build with RelWithDebInfo increased by 29GB,
for a total of almost 50GB.

This is too big, so disable incremental linking to reduce build size.

A previous PR removed the unused /LTCG linker flag,
which was also disabling incremental linking,
permitting the build to stay under a certain size.
Now that the incremental linking is enabled again,
the size of a full build with RelWithDebInfo increased by 29GB,
for a total of almost 50GB.

This is too big, so disable incremental linking to reduce build size.
@Smjert Smjert added build Windows cmake pure cmake changes labels Jan 12, 2021
@mike-myers-tob mike-myers-tob merged commit 107a744 into osquery:master Jan 14, 2021
@mike-myers-tob mike-myers-tob deleted the stefano/build/windows-disable-ilk branch January 14, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build cmake pure cmake changes Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants