Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Do not attempt to dllimport Thrift symbols #6856

Merged
merged 1 commit into from
Dec 28, 2020
Merged

CMake: Do not attempt to dllimport Thrift symbols #6856

merged 1 commit into from
Dec 28, 2020

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Dec 27, 2020

The THRIFT_STATIC_DEFINE define should be publicly used,
because it's used in a header that will be included by osquery.

@Smjert
CMake: Do not attempt to dllimport Thrift symbols
4c7894d 
The THRIFT_STATIC_DEFINE define should be publicly used,
because it's used in a header that will be included by osquery.
@Smjert Smjert added build cmake pure cmake changes libraries For things referring to osquery third party libraries labels Dec 27, 2020
@theopolis theopolis merged commit 7455824 into osquery:master Dec 28, 2020
@mike-myers-tob mike-myers-tob deleted the stefano/build/fix-thrift-dllimport branch January 5, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

Assignees
No one assigned
Labels
build cmake pure cmake changes libraries For things referring to osquery third party libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Smjert @theopolis