Improve fuzzing speed and stack trace accuracy #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a special define when osquery is built for fuzzing. With that is possible to enable code that ignores changing log levels. With the config fuzzer, even if the fuzzer code was settings the minloglevel to 4, that was immediately changed by the osquery logic. Do not run queries parsed from the config to improve the config fuzzer performance and avoid oom issues. When built for fuzzing, compile osquery and libraries without optimizing the frame pointer away. This in some cases improves the accuracy of the stack trace presented when a bug is found.
theopolis
approved these changes
Dec 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a special define when osquery is built for fuzzing.
With that is possible to enable code that ignores
changing log levels.
With the config fuzzer, even if the fuzzer code was settings
the minloglevel to 4, that was immediately changed by the osquery logic.
Do not run queries parsed from the config to improve
the config fuzzer performance and avoid oom issues.
When built for fuzzing, compile osquery and libraries
without optimizing the frame pointer away.
This in some cases improves the accuracy of the stack trace
presented when a bug is found.
The config fuzzer was getting stuck on queries that would take all the time available to run, or would consume more than 2.5GB of memory, which is the limit oss-fuzz uses.
With Valgrind in front, instead of ASAN, a simple one line query with a join on all columns would consume 16GB+ of memory.