Fix last_connected column in wifi_networks on Catalina #6669
Conversation
|
For a reason I don't understand, the code to get the OS version behaves differently in the test, even though it works when running osquery directly. Is there a "registry" of resources in osquery that is not set up properly by the test logic, to allow the wifi_networks table to call another table? auto qd = SQL::selectAllFrom("os_version");
if (qd.size() != 1) {
return Status(-1, "Couldn't determine macOS version");
}When running the test,
|
|
I figured it out, there is some undocumented setup that needs to be done in the test files. We gotta document this stuff. 😤 |
|
|
||
| // Adjust the keys to read, based on the version of macOS | ||
| Status getKnownWifiNetworkKeys(std::map<std::string, std::string>& keys) { | ||
| auto qd = SQL::selectAllFrom("os_version"); |
There was a problem hiding this comment.
I don't like this approach but I see it used in several other places so we can follow up and fix this later.
There was a problem hiding this comment.
It's a table with one row in this case, but I can see it has been a performance problem in other cases in the past?
I've added a macOS version check, and if the version is 10.15 or above, it references a changed key name for the field in the plist that fills the
last_connectedcolumn, restoring the functionality of that column.Related to #6235