Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file_events: Add configuration flag #6663

Merged
merged 2 commits into from
Dec 12, 2020
Merged

file_events: Add configuration flag #6663

merged 2 commits into from
Dec 12, 2020

Conversation

alessandrogario
Copy link
Member

@alessandrogario alessandrogario commented Sep 23, 2020 •
edited

This allows Linux users to configure the process_file_events table without enabling file_events by mistake. Solves issue #5584

@alessandrogario alessandrogario added bug macOS Linux events Related to osquery's evented tables or eventing subsystem labels Sep 23, 2020
@alessandrogario alessandrogario force-pushed the alessandro/bugfix/add-missing-file_events-configuration-flag branch 2 times, most recently from c85f8a7 to ea103c4 Compare September 23, 2020 14:05
directionless
directionless reviewed Sep 30, 2020
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tentatively in favor, but wonder if we should bounce this through a blueprint. We are, after all, thinking about changing the CLI interface.

And if we want to, we should really start supporting --enable-foo and not just --disable-foo=false

@alessandrogario alessandrogario force-pushed the alessandro/bugfix/add-missing-file_events-configuration-flag branch from ea103c4 to f935fa2 Compare October 28, 2020 14:14
@alessandrogario alessandrogario marked this pull request as draft November 1, 2020 09:41
@alessandrogario alessandrogario force-pushed the alessandro/bugfix/add-missing-file_events-configuration-flag branch from f935fa2 to 6898c13 Compare November 19, 2020 18:35
@alessandrogario alessandrogario marked this pull request as ready for review November 19, 2020 18:35
@alessandrogario alessandrogario added the ready for review Pull requests that are ready to be reviewed by a maintainer label Nov 19, 2020
@Smjert Smjert closed this Nov 21, 2020
@Smjert Smjert reopened this Nov 21, 2020
@alessandrogario alessandrogario force-pushed the alessandro/bugfix/add-missing-file_events-configuration-flag branch from 6898c13 to 963ed0d Compare November 23, 2020 21:21
theopolis
theopolis requested changes Dec 5, 2020
View reviewed changes
osquery/events/darwin/fsevents.cpp Outdated Show resolved Hide resolved
@alessandrogario
file_events: Add configuration flag
155ebc9 
This allows Linux users to configure the process_file_events table
without enabling file_events by mistake.
@alessandrogario
file_events: Code review changes
5a369e7
@alessandrogario alessandrogario force-pushed the alessandro/bugfix/add-missing-file_events-configuration-flag branch from 963ed0d to 5a369e7 Compare December 9, 2020 16:23
@theopolis theopolis merged commit 8a3c856 into osquery:master Dec 12, 2020
@mike-myers-tob mike-myers-tob removed the ready for review Pull requests that are ready to be reviewed by a maintainer label Dec 18, 2020
@mike-myers-tob mike-myers-tob deleted the alessandro/bugfix/add-missing-file_events-configuration-flag branch December 18, 2020 06:57
@mike-myers-tob mike-myers-tob mentioned this pull request Feb 24, 2021
Closed
aikuchin pushed a commit to aikuchin/osquery that referenced this pull request Jul 11, 2023
@lexuxor
Merge pull request osquery#14 in CLOUD/osquery from sync/osquery-4.6.…
1fa4329 
…0 to master

* commit '2685844e7a4b1dbddd786f0ab3c1d26656deff28': (62 commits)
  CHANGELOG 4.6.0 (osquery#6809)
  Merge pull request from GHSA-4g56-2482-x7q8
  cpack: Use CPACK_RPM_PACKAGE_RELEASE (osquery#6805)
  CMake: add max version limit to 3.18.0 on Linux (osquery#6801)
  libs: Update sqlite to version 3.34.0 (osquery#6804)
  Add indexed column support to Windows users table (osquery#6782)
  file_events: Add configuration flag (osquery#6663)
  CI: Make the built packages available to be downloaded (osquery#6772)
  Remove a Buck leftover (osquery#6799)
  CI: Update brew scripts (osquery#6794)
  CI: Python installation improvements on Windows (osquery#6764)
  BPF: Fix the tests (osquery#6783)
  libs: Update bzip2 to version 1.0.8 (osquery#6786)
  Update cmake_minum_required to 3.17.5 and pin version in CI (osquery#6770)
  CMake: Remove unused LTCG flag (osquery#6769)
  Remove boost workaround introduced in osquery#5591 for string_view (osquery#6771)
  libs: Update BPF libraries to support LLVM 11 (osquery#6775)
  BPF: Fix wrong d_type compare in fs classes (osquery#6774)
  startup_info: Fix memory leak in the dbus classes (osquery#6773)
  Change urls for submodules gpg-error, libgcrypt, libcap (osquery#6768)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless left review comments

@theopolis theopolis theopolis approved these changes

Assignees
No one assigned
Labels
bug events Related to osquery's evented tables or eventing subsystem Linux macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alessandrogario @directionless @theopolis @Smjert @mike-myers-tob