Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog 4.5.1 #6692

Merged
merged 5 commits into from
Oct 5, 2020
Merged

Conversation

directionless
Copy link
Member

@directionless directionless commented Oct 4, 2020

No description provided.

Copy link
Contributor

@muffins muffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm! Thanks a lot for putting this together, I had a couple of notes/comments/questions for you if you don't mind.

CHANGELOG.md Outdated
[Git Commits](https://github.com/osquery/osquery/compare/4.5.0...4.5.1)


### New Features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Features could maybe be a level 2 header as it seems the level 3s below are all associated with it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands, All subheadings are 3 deep, and nested under the 4.5.1 tag. Previously, we had ## New Features / Under the Hood improvements but it felt better split. There are no items in New Features

I suspect it looks more sensible in the whole view. and not the diff. But maybe there's something more clear

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@theopolis
Copy link
Member

Ok, the final few fixes have been merged. This PR is the next step towards a 4.5.1.

@directionless directionless marked this pull request as ready for review October 5, 2020 14:22
@directionless directionless merged commit 335c013 into osquery:master Oct 5, 2020
@directionless directionless deleted the seph/changelog-4.5.1 branch October 5, 2020 17:04
aikuchin pushed a commit to aikuchin/osquery that referenced this pull request Jul 11, 2023
…1 to master

* commit 'dc2c7d0ef21f7913448c664ae0ebddd034afc977': (43 commits)
  Changelog 4.5.1 (osquery#6692)
  Fix incorrect stat return checking within process_events (osquery#6694)
  tests: Reduce flakiness of test_osqueryi (osquery#6688)
  Flush stdout with --help (osquery#6693)
  Enable cppcheck target in macOS builds (osquery#6685)
  Fix dirPathsAreEqual the documented way (osquery#6690)
  Add broad exception catching for table execution (osquery#6689)
  Authenticode table with catalog file info (osquery#6677)
  Document max interval for scheduled queries (osquery#6683)
  Fix container overflow in curl_certificate (osquery#6664)
  Update documentation around build steps (osquery#6681)
  Incorporate suggested changes on PR 5789 from Directionless
  Copy-edit and Markdown lint the remaining deployment docs
  Copy-edit and Markdown lint, clarify section headers for HTTP API doc
  Copy-edit and Markdown lint, remove old comment about CI
  Copy-edit and Markdown lint many deployment docs
  Fixed handling of invalid array bound error with EvtNext function (osquery#6660)
  Copy-edit and Markdown lint (just nits) remaining developer docs
  Copy-edit and Markdown lint (just nits) several developer docs
  Copy-edit and Markdown lint the configuration plugin guidance; minor clarification
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants