events: Remove selectAllFrom from linux process events callback #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa0cfa6
to
f93891b
Compare
alessandrogario
approved these changes
Sep 8, 2020
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…0 to master * commit 'ab092654b8b027e35a91ef19feb74f9eeec0fc2b': (98 commits) osquery-4.5.0: merge updates and fix conflicts osquery-4.5.0: merge updates and fix conflicts Add 4.5.0 CHANGELOG (osquery#6646) Add sigurl column to pass yara signatures with the queries (osquery#6607) Update process auditing docs schema link (osquery#6645) Support for Background Activity Moderator (osquery#6585) database: Remove read only concept (osquery#6637) Parsing of user data in Windows event log (osquery#6643) events: Remove selectAllFrom from linux process events callback (osquery#6638) libs: Set glog and gflags includes as SYSTEM (osquery#6635) tests: Fix flaky test_2_daemon_with_option (osquery#6634) tests: Improve the reliability of TLSServerRunner (osquery#6632) database: Move initialization retry logic into DB API (osquery#6633) libs/smartmontools: Add aarch64 support libs/lzma: Add aarch64 support libs/lldpd: Add aarch64 support libs/librdkafka: Add aarch64 support libs/libgpg-error: Add aarch64 support libs/libgcrypt: Add aarch64 support libs/libdpkg: Add aarch64 support ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By looking at a graph of CPU usage for the Linux audit event publishers, it seems like we can save some CPU usage on this hot path. The
selectAllFromis a convenience function to abstract whatfilereturns. We do not need the x-platform feature from this, nor most of the returned results. So we can callstatdirectly in the callback.