Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows build removing non existing C11 conformance #6629

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix Windows build removing non existing C11 conformance #6629

merged 1 commit into from
Sep 3, 2020

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Sep 3, 2020 •
edited

thirdparty_librdkafka_c was failing to compile
due to the C11 keyword _Thread_local not being recognized.

Note: This began failing recently due to a CMake update in the Windows agent which "respects" our request to use C11.

@Smjert
Fix Windows build removing non existing C11 conformance
15c15e4 
thirdparty_librdkafka_c was failing to compile
due to the C11 keyword _Thread_local not being recognized.
@Smjert Smjert added build cmake pure cmake changes Windows labels Sep 3, 2020
@theopolis theopolis merged commit d0b4e32 into osquery:master Sep 3, 2020
@Smjert Smjert deleted the stefano/build/fix-msvc-c11 branch October 17, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

Assignees
No one assigned
Labels
build cmake pure cmake changes Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Smjert @theopolis