Rejigged aarch64 port #6612
Merged
Rejigged aarch64 port #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This supersedes #6336 |
theopolis
requested changes
Aug 29, 2020
We currenty inclulde unistd_64.h which doesn't work on aarch64. Rather add #ifdef's around it, let's just use unistd.h which should do the right thing on all architectures. Additionally remove the duplicate #include's from the .cpp files
Currently recognizes AMD64 and x86_64 for x86 and aarch64 for ARM. Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Instead of hard-wiring "x86_64" Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Some syscalls are deprecated on newer architectures, for example fork and vfork are all variants of clone now; symlink, unlink, rename etc... at variants of the *at() versions, dup2 of dup3, etc... Note about the test events: Because the events are synthetic, we only really test the parser, as such it doesn't matter if aarch64 doesn't use a snapshot of a real event. To keep things simple we only replace the arch and syscall fields. Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
The instruction doesn't exist on other processors, and while there might be ways to retrieve the equivalent information, none directly matches the x86 "cpuid". This takes out the table completely on non-x86_64 architectures. Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org> Co-Authored-By: Alessandro Gario <alessandro.gario@gmail.com>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org> Co-Authored-By: Alessandro Gario <alessandro.gario@gmail.com>
Co-Authored-By: Benjamin Herrenschmidt <benh@kernel.crashing.org>
theopolis
approved these changes
Sep 4, 2020
alessandrogario
approved these changes
Sep 5, 2020
|
This is great! I was able to build the packages from scratch on Ubuntu 16 (posted in the arm-architecture Slack channel), and play around with audit. Seems like the first commit in the PR does not contain the co-author tag so if we want to squash and merge we need to make sure to fix it. It's not an issue if we rebase and merge |
The first commit is entirely mine :-) It cleans up the existing usage of unistd_64.h so we don't need the #ifdef's that were in Artemis patch. That said, if you want to add the co-author tag, be my guest, I don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and slightly reworked version of Artemis original aarch64 port:
the use of ifdef's and what I generally feel is a bit cleaner.
one. If we feel strongly about putting that back, I would do it with a different style of
ifdef'ery than what was used in the original port.
It passes the checks on Ubuntu 18.04 AWS x86_64 and aarch64 instances, with the exception
of tools_tests_testfschangestable which appears to have unrelated docker issues.