Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powershell_events: Fix bool type usage #6584

Conversation

alessandrogario
Copy link
Member

@alessandrogario alessandrogario commented Aug 7, 2020

This should fix #6583, caused by the recent Windows Event Log refactor. The malformed_field variable was originally a counter, which was then turned into a boolean flag. When this change happened, two of the original lines that incremented the value survived, causing the bool++ issue.

@alessandrogario alessandrogario added events Related to osquery's evented tables or eventing subsystem Windows labels Aug 7, 2020
@alessandrogario alessandrogario force-pushed the alessandro/bugfix/fix-bool-usage-in-powershell-events branch from 6b0c0be to aabbf9d Compare August 7, 2020 14:12
@theopolis theopolis merged commit 6c98ab3 into osquery:master Aug 8, 2020
@alessandrogario alessandrogario deleted the alessandro/bugfix/fix-bool-usage-in-powershell-events branch August 8, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
events Related to osquery's evented tables or eventing subsystem Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSQuery failed due to error C2428 under /std:c++latest +MSVC
2 participants