Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'denylist' instead of 'blacklist' in query scheduling #6487

Merged
merged 4 commits into from
Jun 6, 2020
Merged

Use 'denylist' instead of 'blacklist' in query scheduling #6487

merged 4 commits into from
Jun 6, 2020

Conversation

zwass
Copy link
Member

@zwass zwass commented Jun 5, 2020

  • Remove racialized language from schedule related code and tables.
  • Alias 'denylisted' column in osquery_schedule table to 'blacklisted'
    for backwards compatibility.
  • Update documentation.

First step of #6475

@zwass
Use 'denylist' instead of 'blacklist' in query scheduling
7c05229 
- Remove racialized language from schedule related code and tables.
- Alias 'denylisted' column in osquery_schedule table to 'blacklisted'
  for backwards compatibility.
- Update documentation.

First step of osquery#6475
@zwass zwass added documentation refactor Related to osquery code refactoring query-scheduler Query scheduler related. labels Jun 5, 2020
@zwass zwass requested a review from theopolis June 5, 2020 23:19
@zwass
Copy link
Member Author

zwass commented Jun 5, 2020

I need to add a check that allows 'blacklist' to be used in the scheduled query, otherwise this is going to be a breaking API change.

@zwass zwass force-pushed the remove-schedule-blacklist branch from 2cccac3 to e13bad0 Compare June 5, 2020 23:48
@zwass
Copy link
Member Author

zwass commented Jun 6, 2020

I made the change to support the deprecated flag. I tested locally with both the deprecated blacklist flag and the new denylist flag.

@zwass zwass mentioned this pull request Jun 6, 2020
Closed
6 tasks
@theopolis theopolis merged commit 4e1d31c into osquery:master Jun 6, 2020
@zwass zwass mentioned this pull request Jun 6, 2020
Closed
@mike-myers-tob mike-myers-tob mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

Assignees
No one assigned
Labels
documentation query-scheduler Query scheduler related. refactor Related to osquery code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zwass @theopolis