Fix the handling of empty args strings, on Windows #6460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6403
As seen in Windows'
startup_items
, if there's a startup item entry in the registry key which does not have an associated value, then an empty string is passed to a osquery helper function that tries to parse it into anargs
array. But it uses a Windows API that, if passed an empty string, fills in the command line args of the current osquery process, instead. This PR catches the empty string before that happens.