Add 'vendor', 'package_group' columns to rpm_packages #6443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
previously approved these changes
May 20, 2020
zwass
previously approved these changes
May 20, 2020
|
@directionless missing values seem to be handled in |
|
@directionless Yes, missing tags are handled by getRPMAttribute and this has been tested on CentOS 6. |
635737f
to
0f9714c
Compare
|
@directionless, @zwass I realized that |
theopolis
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for the deb_packages table we expand the rpm_packages table, to add more information about the packages installed on the distribution and to better filter them. The two columns added are: vendor, group.
These are standard/official fields in the rpm database.
I've also enabled its respective integration test.