system_info table: add "board_xxx" columns like "hardware_xxx" #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out hardware_xxx is not useful in SuperMicro servers hardware_model Actual: Super Server Expect: X11SSH-F hardware_version Actual: 0123456789 Expect: 1.01 hardware_serial Actual: 0123456789 Expect: WM199xxxxxxx
|
Thanks for this! The next step is signing the CLA. |
|
theopolis
approved these changes
Apr 18, 2020
|
nice, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out hardware_xxx is not useful in SuperMicro servers
To submit a PR please make sure to follow the next steps:
CONTRIBUTING.mdguide on the root of the repo.format_checktarget,if not move the committed files to the stage area,
build the
formattarget to format, then re-commit.More information is available on the wiki.