Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Update SQLite from 3.30.1 to 3.31.1 #6252

Conversation

alessandrogario
Copy link
Member

@alessandrogario alessandrogario commented Feb 18, 2020

This PR updates the SQLite library in the CMake source dependency layer from version 3.30.1 to 3.31.1.

Issue: #6250 - outdated SQLite in osqueryd.exe

@alessandrogario alessandrogario added libraries For things referring to osquery third party libraries cmake pure cmake changes labels Feb 18, 2020
@alessandrogario alessandrogario force-pushed the alessandro/libs/update-sqlite-to-3_31_1 branch from 1ef453b to d4ce74c Compare February 18, 2020 20:40
@theopolis
Copy link
Member

Are there any needed features, or features to highlight, in this new version?

@great944
Copy link

Our SCA tools flags SQLite as outdated and insists that its a critical issue for some reason , using black duck

@alessandrogario
Copy link
Member Author

alessandrogario commented Feb 24, 2020

Our SCA tools flags SQLite as outdated and insists that its a critical issue for some reason , using black duck

I am not sure whether this PR will fix the warning as we probably do have SQLite versions around that are not used to produce release binaries. Updating the library is still a good idea though.

The version we are using for releases is stored inside libraries/cmake/source/sqlite, and is currently tracking 3.30.1.

Can you show us an excerpt from the report?

Quick reminder on how libraries work within osquery

BUCK

  • ./third-party: These libraries are old, and it's not easy to update them. This build system is not used for production or development, and is only kept for compatibility.
  • ./libraries/buck: Currently empty

CMake

This is what most people will use for development. It is mandatory, when generating releases.

Libraries are organized in folders that can be layered; the first one has the highest priority, and if it doesn't contain a required library, CMake will inspect the next one.

  • ./facebook: The same pre-compiled libraries that BUCK uses, which are to be considered deprecated. Linux no longer depends on this folder for libraries (but does for some build-time tools that are not linked inside osquery). Windows and macOS are being detached from it.
  • ./formula: Reserved for OpenSSL
  • ./source: All the new libraries. Linux imports everything exclusively from here.
  • ./source_migration: Links to the libraries inside source that have been made compatible with macOS and Windows.

The layer configuration can be seen here: https://github.com/osquery/osquery/blob/master/cmake/options.cmake#L81

@alessandrogario alessandrogario merged commit f3ca4f5 into osquery:master Feb 24, 2020
@alessandrogario alessandrogario deleted the alessandro/libs/update-sqlite-to-3_31_1 branch February 24, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake pure cmake changes libraries For things referring to osquery third party libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants