tables: Match column attributes to usage #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
previously requested changes
Dec 13, 2019
| @@ -4,7 +4,7 @@ schema([ | |||
| Column("type", TEXT, "Type of crash log"), | |||
| Column("pid", BIGINT, "Process (or thread) ID of the crashed process"), | |||
| Column("path", TEXT, "Path to the crashed process"), | |||
| Column("crash_path", TEXT, "Location of log file"), | |||
| Column("crash_path", TEXT, "Location of log file", index=True), | |||
There was a problem hiding this comment.
I don't see this in the c++ implementation, and looking at my machine, I think it's incorrect from a primary key perspective.
crash_path could, maybe, be a primary key.
| @@ -2,8 +2,8 @@ table_name("docker_container_processes") | |||
| description("Docker container processes.") | |||
| schema([ | |||
| Column("id", TEXT, "Container ID", index=True, required=True), | |||
| Column("pid", BIGINT, "Process ID"), | |||
| Column("name", TEXT, "The process path or shorthand argv[0]", index=True), | |||
| Column("pid", BIGINT, "Process ID", index=True), | |||
There was a problem hiding this comment.
I don't see this used as an index. Maybe additional?
There was a problem hiding this comment.
The combination of id and pid are the PRIMARY KEY for this table.
|
Thanks for the review, I will make some follow up changes. Like you pointed out, I intentionally added several |
2734975
to
5e2e171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did another audit of table implementations and how they use column constraints. These changes seem to match how I saw the constraints used and what makes sense from a primary-key == index perspective.