Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding docker image layers table #6154

Merged
merged 3 commits into from
Jan 12, 2020
Merged

adding docker image layers table #6154

merged 3 commits into from
Jan 12, 2020

Conversation

scoders-tob
Copy link
Contributor

@scoders-tob scoders-tob commented Dec 30, 2019 •
edited

This table lists constituent layers of a docker image.

Example output:

osquery> select * from docker_image_layers where id = 'bcb0317';
+---------+------------------------------------------------------------------+-------------+
| id      | layer_id                                                         | layer_order |
+---------+------------------------------------------------------------------+-------------+
| bcb0317 | cc967c529ced563b7746b663d98248bc571afdb3c012019d7f54d6c092793b8b | 1           |
| bcb0317 | 2c6ac8e5063e35e91ab79dfb7330c6154b82f3a7e4724fb1b4475c0a95dfdd33 | 2           |
| bcb0317 | 6c01b5a53aac53c66f02ea711295c7586061cbe083b110d54dafbeb6cf7636bf | 3           |
| bcb0317 | e0b3afb09dc386786d49d6443bdfb20bc74d77dcf68e152db7e5bb36b1cca638 | 4           |
| bcb0317 | f702eabea3b99cb38d912fa018a2692cedf0367101cfe4a002da31b1836e6909 | 5           |
| bcb0317 | ab11d8128d1eb55778e2906f09d63a800dde4bf61ef7be5ac0c206ba866aa3d9 | 6           |
| bcb0317 | 95ec16cce2bdccb7372f9d187c551122721d6bbbfb731df4449e8e5a284e972c | 7           |
| bcb0317 | ca830ef3a3f312d38bc36c87a807890fd333a6ad2b69ad6de9008f741318c7b5 | 8           |
+---------+------------------------------------------------------------------+-------------+

@scoders-tob scoders-tob changed the title adding docker images table adding docker image layers table Dec 30, 2019
@scoders-tob
Copy link
Contributor Author

scoders-tob commented Dec 31, 2019 •
edited

Closing this temporarily. Will repoen with an imageID-specific optimization.

@scoders-tob scoders-tob reopened this Jan 1, 2020
theopolis
theopolis requested changes Jan 4, 2020
View reviewed changes
osquery/tables/applications/posix/docker.cpp Outdated
}

Row r;
for (int index = 0; index < layers.size(); index++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick and this looks good to go, prefer size_t over int here.

@scoders-tob
Copy link
Contributor Author

Thanks @theopolis! Done.

@theopolis theopolis merged commit 6c9f8e3 into osquery:master Jan 12, 2020
@mike-myers-tob mike-myers-tob deleted the layerstable branch May 7, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

@alessandrogario alessandrogario Awaiting requested review from alessandrogario

Assignees
No one assigned
Labels
feature virtual tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scoders-tob @theopolis @Smjert @scoders