Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Change Python version required to be at least 3.5 #6081

Merged

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Nov 25, 2019

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes #6079

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079
@Smjert
Copy link
Member Author

Smjert commented Nov 25, 2019

It was originally not using 3.8 because it was recently added on Azure Pipelines Windows VMs only and the Python tests would fail again.
I was thinking of having the Python tests "quickly" merged, so that we could've them running, but due to the freeze and CLA issues, merging slowed down.
So now there's time to properly add Python 3.8 support on those tests; I just hope it's backward compatible enough for the Python versions we want to cover.

@Smjert Smjert added build cmake pure cmake changes labels Nov 25, 2019
@theopolis theopolis merged commit 501b924 into osquery:master Nov 26, 2019
rachelcipkins pushed a commit to trailofbits/osquery that referenced this pull request Nov 27, 2019
Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079
rachelcipkins pushed a commit to trailofbits/osquery that referenced this pull request Nov 27, 2019
Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079
rachelcipkins added a commit to trailofbits/osquery that referenced this pull request Nov 27, 2019
Updated chrome parameters and added opera function.

Updated to include opera specific function.

Added permissions and profile rows.

CMake: Change Python version required to be at least 3.5 (osquery#6081)

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079

CMake: Change Python version required to be at least 3.5 (osquery#6081)

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079
rachelcipkins added a commit to trailofbits/osquery that referenced this pull request Nov 27, 2019
Updated chrome parameters and added opera function.

Updated to include opera specific function.

Added permissions and profile rows.

CMake: Change Python version required to be at least 3.5 (osquery#6081)

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079

CMake: Change Python version required to be at least 3.5 (osquery#6081)

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079

Added Brave/Chromium support.

Updated chrome parameters and added opera function.

Updated to include opera specific function.

Added permissions and profile rows.

CMake: Change Python version required to be at least 3.5 (osquery#6081)

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079

Added Brave/Chromium support.

Updated chrome parameters and added opera function.

Updated to include opera specific function.

Added permissions and profile rows.

CMake: Change Python version required to be at least 3.5 (osquery#6081)

Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079
rachelcipkins pushed a commit to trailofbits/osquery that referenced this pull request Dec 10, 2019
Removed the restriction for the Python version to be >= 3.6 but < 3.8.
Now it has to be >=3.5, lower versions are EOL.

Removed the search for Python2 too since nothing uses it anymore.

Fixes osquery#6079
@Smjert Smjert deleted the stefano/fix/python3-version-selection branch December 19, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build cmake pure cmake changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

osquery build broken with Python 3.5
2 participants