logging: Change logNumericsAsNumbers to numerics and add docs #6002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an API change for the format of logged events. The top-level log field "logNumericsAsNumbers" was introduced to help migrate from string-encoded numerics to JSON numbers. This change updates the field to be "numerics", updates the flag to conform to flag naming conventions, and documents the expectation.
directionless
approved these changes
Nov 7, 2019
|
Yeah, also the field is already included (using a different name) for the 4.0.2 release. That's not great but ideally we'd talk longer about adding new fields, what they should be called, if they are needed, etc. This is a good feature to have, hopefully we can switch the default to not be 'all strings all the time' in the future. This will require some comms / planning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API change for the format of logged events. The top-level log field "logNumericsAsNumbers" was introduced to help migrate from string-encoded numerics to JSON numbers.
This change updates the field to be "numerics", updates the flag to conform to flag naming conventions, and documents the expectation.