tools: move webcrypto into no-restricted-properties #53023
Conversation
| @@ -7,7 +7,7 @@ if (!common.hasCrypto) | |||
| const assert = require('assert'); | |||
| const crypto = require('crypto'); | |||
|
|
|||
| /* eslint-disable no-restricted-syntax */ | |||
| /* eslint-disable no-restricted-properties, no-restricted-syntax */ | |||
There was a problem hiding this comment.
Do we still need to disable no-restricted-syntax?
| /* eslint-disable no-restricted-properties, no-restricted-syntax */ | |
| /* eslint-disable no-restricted-properties */ |
There was a problem hiding this comment.
Looks like the no-restricted-syntax error comes from test/.eslintrc.yaml here I think the no-restricted-properties should also be added into test/.eslintrc.yaml in order to keep the rule consistent.
There was a problem hiding this comment.
Adding no-restricted-properties into test/.eslintrc.yaml will result in more linting errors in other test files. I have added a TODO which I will try to fix in a separate PR.
ef00f15
to
d34b551
Compare
|
Can you rebase please? With the move to flat config, there are some conflicts to solve. |
d34b551
to
40fe042
Compare
Hi @aduh95, I have rebased my branch. Could you please take a look again and rerun CI for me? Thanks. I have also removed my |
|
The linter is failing (also it looks like the TODO is still there?) |
Since eslint fixed eslint/eslint#16412 and we are on eslint v8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto.
40fe042
to
55cd7e8
Compare
Oh sorry. I accidentally dropped one of my commit during interactive rebase. Thank you for spotting it! It should be fixed by now. |
|
Hi @aduh95, I am still seeing 4 failing CI jobs (feels like flaky tests) could you help me take a look, please? Thanks a lot ! 👀 |
|
Landed in 74dff83 |
Since eslint fixed eslint/eslint#16412 and we are on eslint v8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto. PR-URL: #53023 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Since eslint fixed eslint/eslint#16412 and we are on eslint v8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto. PR-URL: nodejs#53023 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Since
eslintfixed eslint/eslint#16412 inv8.56.0here and we are oneslintv8.57.0so that we can take advantage ofno-restricted-propertiesrule forwebcrypto.This is my first pull request to node.js. Please let me know if there is anything to fix.