Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proper sorting of numbers / IP #1175

Closed
FabioPedretti opened this issue Feb 26, 2024 · 4 comments
Closed

proper sorting of numbers / IP #1175

FabioPedretti opened this issue Feb 26, 2024 · 4 comments
Labels
assigned-to-project

Comments

@FabioPedretti
Copy link

Hi, and Thanks for developing netdisco! ️🙂

In Reports -> IP -> Subnet Uilization if I sort by size, the sorting is done by alphabet and not numeric (in the image 16 should be the first, followed by the 256, then 1.024 and at last the 1.048.576):
nd-size

The same issue happens when sorting by IP (e.g. it shows 10.1.0.0 followed by 10.10.0.0 and then 10.2.0.0, while I would expect it should be 10.1.0.0 followed by 10.2.0.0 and then 10.10.0.0).

Thanks.
ollyg added a commit that referenced this issue Mar 13, 2024
@ollyg
#1175 sort subnet column correctly in subnets report
ba5a518
@ollyg
Copy link
Member

ollyg commented Mar 13, 2024

Hi @FabioPedretti
These issues are fixed in the next release, thanks for the bug report!

@ollyg ollyg closed this as completed Mar 13, 2024
ollyg added a commit that referenced this issue Mar 13, 2024
@ollyg
#1175 separator for number formatting force to be comma
c1a0526
@inphobia
Copy link
Member

it's always easier to complain (as i'm doing) instead of providing an alternative, but can c1a0526 perhaps be reconcidered?

in french , us used for decimals, and in belgium for dutch, french & german as well.

wall of text with reasoning & background:
b0773b2#commitcomment-141879906

@inphobia inphobia reopened this May 10, 2024
inphobia referenced this issue May 10, 2024
@ollyg
force comma separator for thousands when formatting numbers in templates
b0773b2
@inphobia
Copy link
Member

seems to 2 commits:
c1a0526
b0773b2

ollyg added a commit that referenced this issue May 20, 2024
@ollyg
#1175 add thousands_separator setting to allow localised separator
32c3d5b
@ollyg
Copy link
Member

ollyg commented May 20, 2024

fixed in 32c3d5b with new thousands_separator setting

@ollyg ollyg closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned-to-project
Projects
Bugs Reported
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ollyg @FabioPedretti @inphobia