Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Hidden] Remove component #42305

Closed
wants to merge 1 commit into from
Closed

[material-ui][Hidden] Remove component #42305

wants to merge 1 commit into from

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented May 20, 2024 •
edited

The Hidden component was once removed and brought back in v5. Since it was already deprecated in v5, it's safe to remove it for v6.

TODO:

@aarongarciah aarongarciah added component: Hidden The React component. package: material-ui Specific to @mui/material breaking change labels May 20, 2024
@mui-bot
Copy link

mui-bot commented May 20, 2024 •
edited

Netlify deploy preview

https://deploy-preview-42305--material-ui.netlify.app/

Hidden: parsed: -100.00% 😍, gzip: -100.00% 😍
@material-ui/core: parsed: -0.50% 😍, gzip: -0.67% 😍

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 564ac58

@aarongarciah aarongarciah changed the title [material-ui][Hidden] Remove Hidden component [material-ui][Hidden] Remove component May 20, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 22, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 22, 2024
@aarongarciah aarongarciah marked this pull request as ready for review May 22, 2024 15:06
@aarongarciah aarongarciah added the on hold There is a blocker, we need to wait label May 23, 2024
@aarongarciah
Copy link
Member Author

aarongarciah commented May 23, 2024 •
edited

Let's pause this until we discuss if we want to remove Hidden or revisit its API. Hidden keeps things composable and doesn't force the use of the sx prop for devs not directly using Emotion or Pigment CSS.

@aarongarciah aarongarciah marked this pull request as draft May 23, 2024 15:47
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 27, 2024
@aarongarciah
Copy link
Member Author

We're not removing hidden in v6. We'll revisit this decision for v7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

Assignees
No one assigned
Labels
breaking change component: Hidden The React component. on hold There is a blocker, we need to wait package: material-ui Specific to @mui/material PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aarongarciah @mui-bot