WIP: Move timers from TermControl to Core/Interactivity #15969
Conversation
|
Also, look! The WPF control! This is with the port to ControlCore/ControlInteractivity. VT blink never worked(!), as didn't autoscroll. |
|
There's an option to clean this up even more drastically than this. It's probably too much (given your limited time to code), but I personally think it's a fun idea regardless. In short: You could move the blink on/off state from the ...and use This splits the "cursor on/off" into "blink on/off" and "reset on next frame to be forced on/off". With that done all that remains is to pass the blink interval to this function: terminal/src/renderer/base/thread.cpp Line 192 in 4bc34e4 or to use |
It has access to its own dispatcher, so it can do this on its own. We'll be able to remove the timer from the WPF control in the future as well. TODO: - [ ] Fix "allow cursor while blurred" - [ ] Fix a crash I observed trying to blink a nonexistent text buffer cursor ??? while splitting a bunch of panes all at once - [ ] Test more
This removes "focused" and "pointerPressedInBounds" from the ControlInteractivity API.
0bff156
to
9eb8537
Compare
This WIP PR moves the blink and cursor timers down to Core (where it has unfettered access to everything it needs).
It also puts Core in charge of displaying the cursor when there is input, and managing the cursor's focus visibility.
It also means that Core no longer needs a "BlinkCursor" method?
This PR will allow us to remove the timer from the WPF layer as well.
This PR also moves the autoscroll timer down into ControlInteractivity (!)
which means that all interactivity consumers get it for free. That's RAD.
All the logic is the same.
I also took the opportunity to remove some silly parts of the ControlInteractivity API that supported this, like it needing to be told whether the pointer was pressed while it was inside the box and whether it is focused (???)
Now it darn well keeps track of those things itself.
TODO:
cursor ??? while splitting a bunch of panes all at once