Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks for CRAN compliance #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stevecondylios
Copy link

An error (to do with retrieving badges used in markdown) is avoided by not including the markdown files in the tarball sent to CRAN.

speedtest now passes check --as-cran

speedtest should now pass

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #7 into master will increase coverage by 1.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #7     +/-   ##
=========================================
+ Coverage   12.56%   13.77%   +1.2%     
=========================================
  Files           9        9             
  Lines         183      167     -16     
=========================================
  Hits           23       23             
+ Misses        160      144     -16
Impacted Files Coverage Δ
R/bestest.r 0% <0%> (ø) ⬆️
R/test-main.r 0% <0%> (ø) ⬆️
R/download.r 0% <0%> (ø) ⬆️
R/servers.r 0% <0%> (ø) ⬆️
R/upload.r 0% <0%> (ø) ⬆️
R/util.r 20.83% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38718d8...464e7d6. Read the comment docs.

@hrbrmstr
Copy link
Owner

#ty! Pls add yourself to the DESCRIPTION file as a contributor and I can merge after that. FWIW this wasn't the cause of CRAN pain. One of the folks there just doesn't like console output when it doesn't come from RStudio funded authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants