Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Opower time gaps #117763

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Avoid Opower time gaps #117763

wants to merge 4 commits into from

Conversation

tronikos
Copy link
Contributor

@tronikos tronikos commented May 20, 2024

Breaking change

Proposed change

Change the way Opower fetches historical data to avoid time gaps. In the particular linked issue the account says has ReadResolution.QUARTER_HOUR but that is only after the smart meter was installed in August 2023. Before that, it was ReadResolution.BILL (monthly). Before we were fetching up to 3 years ago monthly data, 3 years ago to 2 months ago daily, and 2 months ago to now hourly. This resulted to time gaps. Now the fetches overlap and cost/usage reads are merged together preferring finer data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Opower: Avoid time gaps Avoid Opower time gaps May 22, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by-code-owner cla-signed integration: opower Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opower - Unexpected error fetching Opower data (Atlantic City Electric)
2 participants