Add alarm clock helper #117755
Add alarm clock helper #117755
Conversation
There was a problem hiding this comment.
This PR has multiple things I do not understand.
Why is this an helper, why can't it just be a blueprint?
Additionally the PR description writes:
This can be used also by various integrations that provide alarms such as
That means this is an entity component platform and not a helper? Or? As in, integrations cannot provide helpers... So the description conflicts itself.
So what is it in this case?
../Frenck
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
I wanted to create something that can be created and configured from the UI, which made me feel like helper is the most relevant approach. However, I also have the use-case where several integrations would provide these. How would you suggest approaching this?
I don't really see a blueprint being a good fit. We already have an integration for timer and I'd like to add proper UI for changing alarm clocks if this PR is accepted. |
|
So this is meant to be a "building block integration" and a "helper" with frontend support, just like the timer. |
A timer is an helper, not an entity component platform (and thus cannot be provided by integration). Timers cannot be provided by integrations for that reason. We do already have an UI for managing and creating timer helpers, so not getting that part of the comment.
This would be different things (an entity component and a input helpers that goes with it). Similar to e.g., a Please note, making such components, requires an architectural proposal and discussion to be approved before making a PR. You can find our architectural repository here: https://github.com/home-assistant/architecture ../Frenck |
|
Thanks, I'll start a discussion there. |
|
Ok, in that case, I'll go ahead and close these PRs up awaiting that proposal to be approved. Once the discussion has been resolved and the proposal approved, these PRs can be re-opened. ../Frenck |
|
Discussion opened here: home-assistant/architecture#1089 |
Proposed change
Add an alarm clock helper that can be used to set alarms. This can be used also by various integrations that provide alarms such as:
https://github.com/theneweinstein/somneo
https://github.com/lukas-clarke/eight_sleep
Without this integration, other integrations need to set up one alarm clock using several individual entities:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: