Get ntp-dev fuzzing again #11589
Get ntp-dev fuzzing again #11589
Conversation
Update fuzz patch for ntp source changes. (issue 59213) Speed one-shot build by sharing config.cache between our 4 configure scripts and disabling dependency tracking. Add Dave Hart and Harlan Stenn to auto_ccs to enable authenticated access to gsutil.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
hart-NTP is a new contributor to projects/ntp. The PR must be approved by known contributors before it can be merged. The past contributors are: joycebrum, devtty1er, Dor1s, catenacyber (unverified) |
|
@DonggeLiu could you trigger CI please ? |
|
Thanks, the failing CI runs are due to a bug I've fixed but hasn't been released yet. I will check back after the corrected ntp-dev is released. [Bug 3835] NTP_HARD_*FLAGS not used by libevent tearoff. hart@ntp.org |
I've pushed a workaround to hart-NTP/oss-fuzz , would you please, would you please approve the workflow again? |
|
Could you fix the errors please? |
840f3ca
to
3cf0b66
Compare
|
@DonggeLiu please trigger CI again. The corrected ntp-dev was finally released. |
Update fuzz patch for ntp source changes. (issue 59213) Speed one-shot build by sharing config.cache between our 4 configure scripts and disabling dependency tracking. Add Dave Hart and Harlan Stenn to auto_ccs to enable authenticated access to gsutil.
Adds libevent to Dockerfile prerequisites to build against the current libevent package rather than the copy bundled with the NTP distribution. Also removes stray newline at end of patch.diff introduced in first attempt
|
@catenacyber @DonggeLiu can one of you help approve this to run CI again? |
done |
…into davehart-59213
Revert earlier workaround attempt which attempted avoid broken libevent tearoff now that that tearoff is fixed in ntp-dev.
|
Thanks @DavidKorczynski, my earlier attempted workaround for the brokenness in ntp-dev fouled some of the CI runs. I've reverted it and need an approving review to trigger CI again. |
|
@catenacyber @DavidKorczynski can one of you review to trigger CI please? |
Done! |
|
You can also test the build locally (or in a virtual machine, if you want to keep you local machine clean) with Also, it may be possible to enable GitHub actions in your fork, to run the CI. But I haven't tried that. |
Update fuzz patch for ntp source changes. (issue 59213).
Speed one-shot build by sharing config.cache between our 4 configure scripts and disabling dependency tracking.
Add Dave Hart and Harlan Stenn to auto_ccs to enable authenticated access to gsutil.