Ruby: Use additional sensitive data heuristics for CleartextSources #16503
+155
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac50b35
to
8d9b489
Compare
alexrford
reviewed
May 23, 2024
| HashKeyWriteSensitiveSource() { | ||
| exists(DataFlow::CallNode writeNode, SensitiveDataClassification classification | | ||
| nameIndicatesSensitiveData(name, classification) and | ||
| not classification = SensitiveDataClassification::id() and |
There was a problem hiding this comment.
Nitpick: I'd prefer an inclusion test to make it more obvious which categories are considered, and maybe make this a less likely to change inadvertently if we add more classifications in the future, e.g.
Suggested change
| not classification = SensitiveDataClassification::id() and | |
| classification = [ | |
| SensitiveDataClassification::secret(), | |
| SensitiveDataClassification::password(), | |
| SensitiveDataClassification::certificate(), | |
| SensitiveDataClassification::private() | |
| ] and |
| // avoid safe values assigned to presumably unsafe names | ||
| not this instanceof NonCleartextSensitive and | ||
| nameIndicatesSensitiveData(name, classification) and | ||
| not classification = SensitiveDataClassification::id() and |
There was a problem hiding this comment.
Ditto the above comment, so perhaps we could move this check out into a helper predicate (isRelevantClassification(SensitiveDataClassification classification) or similar).
| ParameterSensitiveSource() { | ||
| exists(SensitiveDataClassification classification | | ||
| nameIndicatesSensitiveData(name, classification) and | ||
| not classification = SensitiveDataClassification::id() and |
304c65a
to
31d9d99
Compare
|
@alexrford Thanks, I have factored out these into a helper predicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #16446.
This PR expands
CleartextSources.qllto use additional sensitive data heuristics besides passwords.Additionally, the cleartext storage and cleartext logging queries allow implicit read steps at sinks.
This finds new results in Railsgoat (https://github.com/github/codeql-team/issues/2367)