C#: Fix performance issue in EntityFramework modelling #16473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a perfomance issue in how we model flow through EntityFramework
SaveChanges
methods. When data reaches aSaveChanges
method call, we jump (usingSyntheticGlobal
s) to the relevantDbSet<elementType>
properties, and we were previously storing unnecessarily much information in theSyntheticGlobal
s, which could result in a combinatorial explosion.