-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby: Add some method calls as a Source #16471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just wondering about the match against objects.rb
.
ruby/ql/lib/codeql/ruby/experimental/UnicodeBypassValidationQuery.qll
Outdated
Show resolved
Hide resolved
ruby/ql/lib/codeql/ruby/experimental/UnicodeBypassValidationQuery.qll
Fixed
Show resolved
Hide resolved
@Sim4n6 There seems to be a change in the expected output from the tests. Could you verify and update the test data if needed? |
Hey, Well, I don't know what is the issue right away. So I updated the Codeql cli to 2.17.4 and I rerun the codeql test learn to regenerate the expected file 7c0ce64 I am available right away to fix this issue, please explain more thank you |
hey @aibaars , any further improvements that I should do related to this one ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
No description provided.