Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Add some method calls as a Source #16471

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ruby: Add some method calls as a Source #16471

wants to merge 3 commits into from

Conversation

Sim4n6
Copy link
Contributor

@Sim4n6 Sim4n6 commented May 12, 2024

No description provided.

@Sim4n6 Sim4n6 requested a review from a team as a code owner May 12, 2024 08:47
@github-actions github-actions bot added the Ruby label May 12, 2024
@Sim4n6 Sim4n6 mentioned this pull request May 12, 2024
Open
2 tasks
@sidshank sidshank changed the title Add some method calls as a Source Ruby: Add some method calls as a Source May 13, 2024
aibaars
aibaars reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just wondering about the match against objects.rb.

ruby/ql/lib/codeql/ruby/experimental/UnicodeBypassValidationQuery.qll Outdated Show resolved Hide resolved
@Sim4n6 Sim4n6 requested a review from aibaars June 7, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars Awaiting requested review from aibaars

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
external-contribution Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sim4n6 @aibaars @sidshank