Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter_sampling: throttle sampling #8833

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented May 17, 2024

Summary

Add a new filter that allows through only a set fraction of records, also referred to as sampling.

This plugin implements two methods of applying said sampling:

  • random chance based on percentage
  • comb filter

The random chance mode simply compares the random number against the percentage of records to decide if a record will be dropped. Over a long enough period of time this should achieve the desired level of filtering.

The comb filter mode calculate a numerator and a denominator that closely represents the fraction of records to filter and then uses a simple state to filter records as it iterates through records.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Phillip Whelan <phil@calyptia.com>
… records.

This filter can sample either by using a random number or by using a comb-like
filter that will emit X records for each Y steps based on a fraction derived
from the rate.

Signed-off-by: Phillip Whelan <phil@calyptia.com>
…port.

Signed-off-by: Phillip Adair Stewart Whelan <phillip.whelan@chronosphere.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants