windows: build: Enable out_kafka plugin on Windows #8662
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
00137c1
to
4056181
Compare
|
I would just remove AppVeyor entirely, let's not complicate CMake because of it. |
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
Hmm..., AppVeyor CI is still alive. So, would we remove or disable AppVeyor CI from this repo? |
|
Configure it not to run for PRs or similar. I think complicating CMake for it is not a good idea here. It may be better as a separate PR just to remove AppVeyor entirely. |
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
|
I updated to disable almost of the AppVeyor/s CI/CD tasks. To remove this workflow or delete AppVeyor's project should be handled in the separated PR, I believe. |
|
Note, once merged we need to update the release workflow as well to ensure it does not try to pull AppVeyor binaries as this will fail now. |
|
Hi, is this PR able to get merged? Because an article https://laurierhodes.info/node/156 was up to seek opportunity to use out_kafka plugin on Windows. We need to cover this case. :) |
In Windows, we forcibly disabled out_kafka plugin on Windows for OpenSSL linkage issues.
Nowadays, this linkage issue seems to be fixed on CI/CD.
So, I'm trying to enable this plugin on Windows.
In AppVeyor, we still didn't resolved OpenSSL linkage issue. However, we already migrated unit test for Windows on GitHub Actions.
So, the existing reason of AppVeyor is maintaining for ABI or something like that?
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.