Fix using multiple email addresses for sendmail #3598
Conversation
busybox sendmail wants space separated list but To: is comma separated so let sendmail just parse the email body for To:
| @@ -62,7 +62,7 @@ actionunban = | |||
|
|
|||
| # Your system mail command | |||
| # | |||
| mailcmd = /usr/sbin/sendmail -f "<sender>" "<dest>" | |||
| mailcmd = /usr/sbin/sendmail -f "<sender>" -t | |||
There was a problem hiding this comment.
This can provide certain backwards incompatibility for actions based on sendmail-common which doesn't contain recipients in the message body (e. g. <dest> is not included in To: or message doesn't contain To: header).
| @@ -175,6 +175,7 @@ filter = %(__name__)s[mode=%(mode)s] | |||
|
|
|||
| # Destination email address used solely for the interpolations in | |||
| # jail.{conf,local,d/*} configuration files. | |||
| # comma separated list for multiple addresses | |||
There was a problem hiding this comment.
May be valid for sendmail actions (after the "fix"), but not for mail (GNU Mailutils, etc) actions.
|
@caderobinson: Have you progressed on your PR? |
I haven't done anything with it. This change worked for me on several machines just fine but there isn't really any validation and as sebres said it may not work in all cases. For the use I found it not working in it was a container so I just mounted my modified file into it and called it good. I am not a coder, I am a system admin that knows enough python to hack something that fixed my issue. |
busybox sendmail wants space separated list but To: is comma separated so let sendmail just parse the email body for To:
Before submitting your PR, please review the following checklist:
against certain release version, choose
0.9,0.10or0.11branch,for dev-edition use
masterbranchfailregexfor filterXwith sample log lineswithin
fail2ban/tests/files/logs/Xfile