Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zone param in firewallcmd rich rules #3029

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support zone param in firewallcmd rich rules #3029

wants to merge 3 commits into from

Conversation

rechandler12
Copy link

@rechandler12 rechandler12 commented May 23, 2021 •
edited

Before submitting your PR, please review the following checklist:

  • CHOOSE CORRECT BRANCH: if filing a bugfix/enhancement
    against certain release version, choose 0.9, 0.10 or 0.11 branch,
    for dev-edition use master branch
  • CONSIDER adding a unit test if your PR resolves an issue
  • LIST ISSUES this PR resolves
  • MAKE SURE this PR doesn't break existing tests
  • KEEP PR small so it could be easily reviewed.
  • AVOID making unnecessary stylistic changes in unrelated code
  • ACCOMPANY each new failregex for filter X with sample log lines
    within fail2ban/tests/files/logs/X file

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.645% when pulling 45e316f on rechandler12:feature/support_zone_in_rich_rules_firewallcmd into f07e0f7 on fail2ban:master.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021 •
edited

Codecov Report

Merging #3029 (45e316f) into master (f07e0f7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3029   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files          77       77           
  Lines       16183    16183           
  Branches     2672     2672           
=======================================
  Hits        15452    15452           
  Misses        411      411           
  Partials      320      320
Impacted Files Coverage Δ
fail2ban/tests/servertestcase.py 96.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07e0f7...45e316f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rechandler12 @coveralls @codecov-commenter