Update roundcube_errors_log path for Roundcube 1.4 compatibility #2990
Conversation
config/paths-debian.conf
Outdated
| @@ -26,3 +26,5 @@ exim_main_log = /var/log/exim4/mainlog | |||
| # was in debian squeezy but not in wheezy | |||
| # /etc/proftpd/proftpd.conf (SystemLog) | |||
| proftpd_log = /var/log/proftpd/proftpd.log | |||
|
|
|||
| roundcube_errors_log = /var/log/roundcube/errors.log | |||
There was a problem hiding this comment.
Looks like this is default path now (distribution irrelevant)? Doesn't it?
For instance here some hint (at least before roundcube/roundcubemail#7009 it was still called errors) - https://github.com/roundcube/roundcubemail/blob/2321bce4694ee9f155284a7b8c55637c47672e79/INSTALL#L83
If so we'd rather need to change it here -
fail2ban/config/paths-common.conf
Line 93 in 8b66338
There was a problem hiding this comment.
This is somewhat distro-specific, but maybe it should just be changed in the paths-common.conf anyways. By default, the Roundcube logs directory is within the Roundcube app directory. So for example, if you install Roundcube at /opt/roundcube/, the logs will be at /opt/roundcube/logs/. Debian installs Roundcube to /var/lib/roundcube/, and /var/lib/roundcube/logs/ is a symlink to /var/log/roundcube. I'm not sure if all distros do that.
Having said all that, it looks like they started adding the .log suffix in Roundcube 1.4 beta in 2017 (roundcube/roundcubemail#313). It looks like Debian Buster still includes the old 1.3 (which doesn't have this option) as it was likely 1.4 was still in beta at the time of the Buster freeze, however backports and Bullseye both include 1.4.
Is there a way to specify two file names? I guess it should use both /var/log/roundcube/errors.log and /var/log/roundcube/errors to handle both old and new versions of Roundcube.
There was a problem hiding this comment.
yes, it is there:
roundcube_errors_log = /var/log/roundcube/errors
/var/log/roundcube/errors.logunsure it is possible with wildcards in glob pattern (since we need to exclude rotated and zipped logs)
|
@sebres Thanks for your feedback. I updated the PR to modify |
|
Any progress on this PR? |
No description provided.