Update README.md #2195
Update README.md #2195
Conversation
The fail2ban executable are into `/usr/local/bin` with the master branch.
Codecov Report
@@ Coverage Diff @@
## 0.11 #2195 +/- ##
==========================================
- Coverage 95.68% 95.66% -0.03%
==========================================
Files 78 78
Lines 14338 14338
Branches 2266 2266
==========================================
- Hits 13720 13717 -3
- Misses 320 322 +2
- Partials 298 299 +1
Continue to review full report at Codecov.
|
README.md
Outdated
| @@ -56,7 +56,7 @@ Alternatively, you can clone the source from GitHub to a directory of Your choic | |||
| sudo python setup.py install | |||
|
|
|||
| This will install Fail2Ban into the python library directory. The executable | |||
| scripts are placed into `/usr/bin`, and configuration in `/etc/fail2ban`. | |||
| scripts are placed into `/usr/local/bin`, and configuration in `/etc/fail2ban`. | |||
There was a problem hiding this comment.
Hmm... this depends on distribution-version resp. platform where you try to install fail2ban.
I don't think it's correct so... Maybe:
- scripts are placed into `/usr/bin`, and configuration in `/etc/fail2ban`.
+ scripts are placed into `/usr/bin` or `/usr/local/bin`, and configuration in `/etc/fail2ban`.There was a problem hiding this comment.
I change that because the manual install but the fail2ban into /usr/local/bin (where distrib installer usually use /usr/bin
But we can add both.
There was a problem hiding this comment.
or /usr/sbin or /usr/local/sbin since admin-oriented... so may be "scripts are placed in a directory listed in the PATH environment variable (e.g., /usr/bin), ..."
|
@sebres in your experience it still the case right? I changed base to master |
|
Nothing changed between 0.11 and 1.1 concerning this matter, so yes. |
|
@sebres what is overall the flow of accepting PRs: you approved but nobody merged... was it me who failed to press the Merge back then? ;) I guess there are some extra rules enforcing cleaner history etc? Would it be ok to just cherry pick into master? |
Mostly it means either time pressure, or I wanted do it from git (e. g. squash, cherry-pick, whatever) but don't have the repo to hand at that point, and/or just forgotten after all.
Probably... no Idea why it happens.
Sure. |
List of change:
/usr/local/binwith the master branch.Before submitting your PR, please review the following checklist:
against 0.9.x series, choose
masterbranchedit @yarikoptic adjusted branch to be master