Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is remove unused modules #2181

Open
wants to merge 1 commit into
base: 0.11
Choose a base branch
from
Open

is remove unused modules #2181

wants to merge 1 commit into from

Conversation

inztar
Copy link

@inztar inztar commented Jul 15, 2018

I found unused imports, i can remove it?

@coveralls
Copy link

coveralls commented Jul 15, 2018

Coverage Status

Coverage decreased (-0.02%) to 97.544% when pulling 21ac558 on inztar:unused-imports into 4c18a04 on fail2ban:0.11.

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

Merging #2181 into 0.11 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             0.11    #2181      +/-   ##
==========================================
- Coverage   95.66%   95.66%   -0.01%     
==========================================
  Files          78       78              
  Lines       14331    14311      -20     
  Branches     2264     2264              
==========================================
- Hits        13710    13690      -20     
- Misses        321      323       +2     
+ Partials      300      298       -2
Impacted Files Coverage Δ
fail2ban/server/action.py 95.16% <ø> (-0.05%) ⬇️
fail2ban/tests/samplestestcase.py 99.39% <ø> (-0.01%) ⬇️
fail2ban/server/actions.py 90.76% <ø> (-0.11%) ⬇️
fail2ban/tests/actionstestcase.py 100% <ø> (ø) ⬆️
fail2ban/server/asyncserver.py 98.61% <ø> (-0.01%) ⬇️
fail2ban/server/filterpoll.py 85.54% <ø> (-0.18%) ⬇️
fail2ban/tests/observertestcase.py 98.11% <ø> (-0.01%) ⬇️
fail2ban/client/jailreader.py 93.87% <ø> (-0.05%) ⬇️
fail2ban/tests/sockettestcase.py 98.61% <ø> (-0.01%) ⬇️
fail2ban/server/filtergamin.py 97.01% <ø> (-0.05%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c18a04...21ac558. Read the comment docs.

@yarikoptic
Copy link
Member

unless @sebres has objections, could be done I guess, but might cause merge conflicts etc. so better be cleaned up "upon encounter". in any case - probably would need a refresh (merge of 0.11 or rebase) to guarantee that it is still adequate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants