Suggested new jail, filter and action called "blacklist". #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 4, 2016 17:33
All files well documented and tested in the server environment indicated and version of Fail2Ban indicated.
| # | ||
| actionunban = <iptables> -D f2b-<name> -s <ip> -j DROP | ||
| # Remove IP from our ip.blacklist file | ||
| sed -i -e '/<ip>/d' /etc/fail2ban/ip.blacklist |
There was a problem hiding this comment.
file needs spellchecking, better description of the purpose, more uniform (spaces) indentation, and probably different locaation for the ip.blacklist (e.g. under /var/run/fail2ban/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please review the following checklist:
CONSIDER adding a unit test if your PR resolves an issue
Github is all new to me so excuse me if I have not added this suggestion
correctly
LIST ISSUES this PR resolves
Resolves persistent banning / repeat offenders across reboots properly.
I have tried so many suggestions out there to have a persistent banning jail and eventually
customized recidive on my own to achieve this. This logs to a simple text file and also nicely
cleans up after itself.
MAKE SURE this PR doesn't break existing tests
I have thoroughly tested this in my environment Ubuntu 16.04 and Fail2Ban 0.91
KEEP PR small so it could be easily reviewed.
I hope I have the smallest footprint I possibly could.
I am new to Github so excuse me if I am not doing this correctly.
Love Fail2Ban and just want to contribute something I find very useful.
AVOID making unnecessary stylistic changes in unrelated code
Hope I have done no such thing.
ACCOMPANY each new
failregexfor filterXwith sample log lineswithin
fail2ban/tests/files/logs/XfileNo FailRegex's I am have based this blacklist jail on recidive, in other words I have
modified recidive so this could potentially either be considered as its own jail or could
perhaps enhance the existing recidive filter.
All files well documented and tested in the server environment indicated and version of Fail2Ban indicated.