Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, cmd/utils: when configured via flag, in block execution: prefetch all reads from account/storage tries, terminate prefetcher synchronously. #29807

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

core, cmd/utils: when configured via flag, in block execution: prefetch all reads from account/storage tries, terminate prefetcher synchronously. #29807

wants to merge 13 commits into from
+78 −21

Conversation

jwasinger
Copy link
Contributor

@jwasinger jwasinger commented May 20, 2024 •
edited

Pulled out from #29719

@jwasinger
cmd/utils, consensus/beacon, core/state: when configured via stub fla…
35df740 
…g: prefetch all reads from account/storage tries, terminate prefetcher synchronously.
@jwasinger jwasinger changed the title cmd/utils, consensus/beacon, core/state: when configured via stub flag: prefetch all reads from account/storage tries, terminate prefetcher synchronously. cmd/utils, consensus/beacon, core/state: when configured via flag: prefetch all reads from account/storage tries, terminate prefetcher synchronously. May 20, 2024
@jwasinger jwasinger changed the title cmd/utils, consensus/beacon, core/state: when configured via flag: prefetch all reads from account/storage tries, terminate prefetcher synchronously. cmd/utils, consensus/beacon, core/state: when configured via flag, in block execution: prefetch all reads from account/storage tries, terminate prefetcher synchronously. May 20, 2024
@zhaoxiangjunupi
Copy link

jiejuelema

holiman
holiman reviewed May 20, 2024
View reviewed changes
core/state/statedb.go Outdated Show resolved Hide resolved
holiman
holiman reviewed May 20, 2024
View reviewed changes
cmd/utils/flags.go Outdated Show resolved Hide resolved
@jwasinger jwasinger changed the title cmd/utils, consensus/beacon, core/state: when configured via flag, in block execution: prefetch all reads from account/storage tries, terminate prefetcher synchronously. core, cmd/utils: when configured via flag, in block execution: prefetch all reads from account/storage tries, terminate prefetcher synchronously. May 20, 2024
@Mazzika1
Copy link

Okay

@Mazzika1
Copy link

Oaky

@jwasinger
Copy link
Contributor Author

jwasinger commented May 21, 2024 •
edited

Haven't quite got this working yet.... Seems somewhat okay now.

@jwasinger
Copy link
Contributor Author

Full sync benchmark nodes are running around block 12.2 million (bench7 is running this PR with the witness collection flag enabled, bench8 is master)

image

image

image

Witness collection mode is causing additional prefetch reads which all hit the db cache. There appears to be no performance impact.

Prefetcher duplicate/waste metrics cease to be meaningful if --collectwitnesses is passed. The account/storage loads are higher (but again, these hit the db cache so it's not a problem).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman left review comments

@Mazzika1 Mazzika1 Mazzika1 approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwasinger @zhaoxiangjunupi @Mazzika1 @holiman