Handle binary char set introducer #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Others are not supported yet :c
By now, it's the only one parsed charset.
[skip ci]
Lagovas
reviewed
May 23, 2022
tests/test.py
Outdated
| id = get_random_id() | ||
| # DON'T EVER, EVER DO THIS | ||
| # Do not use direct string interpolation for sql values | ||
| # This is just a test example |
There was a problem hiding this comment.
we can avoid using raw sql and build query with sqlalchemy:
>>> from sqlalchemy.sql import expression
>>> from sqlalchemy.sql import operators
>>> unary = expression.UnaryExpression(
sa.Column("column"),
operator=operators.custom_op("_binary"),
type_=sa.Numeric)
>>> str(unary)
'_binary "column"'
Use unary instead of self.test_table.c.value_bytes
Sqlalchemy serializes the test as: ``` INSERT ... VALUES (..., (_binary 'string')...) ``` So it's easier to add support also for parenthese expressions, than fight with sqlalchemy. The syntax in general [1] is defined as: ``` simple_expr: | (expr [, expr] ...) ... ``` But our parser supports only: ``` simple_expr: | (expr) ... ``` Which is enough for most real word cases. Therefore, it's easy to add support for these expressions. [1]: https://dev.mysql.com/doc/refman/8.0/en/expressions.html
Lagovas
reviewed
May 23, 2022
|
|
||
| self.schema_table.create(bind=self.engine_raw, checkfirst=True) | ||
| id = get_random_id() | ||
| insert = self.test_table.insert().values( |
There was a problem hiding this comment.
hm, if sqlalchemy compile query with parentheses, then lets test them both? and use raw sql query to use without parentheses if sqlalchemy doesn't allow compile without them
To use both: with and without parentheses around literal.
Lagovas
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR adds support of mysql _binary charset introducer, which is used at least by java frontend. I would like to add other charsets, but they are not supported by the parser yet. So, if there is no need, I wouldn't do that.
Checklist
with new changes
CHANGELOG.md is updated (in case of notable or breaking changes)Benchmark results are attached (if applicable)Example projects and code samples are up-to-date (in case of API changes)