Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert 'bytes' data_type to BYTEA oid for postgresql #519

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Convert 'bytes' data_type to BYTEA oid for postgresql #519

merged 1 commit into from
Apr 6, 2022

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Apr 5, 2022

Found that bytes data_type not handled properly for postgresql

Checklist

Zhaars
Zhaars reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@Zhaars Zhaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lagovas Do we already have some integration tests that cover that change?

@Lagovas
Copy link
Collaborator Author

Lagovas commented Apr 5, 2022

actually not, because by default all data stored in the database as bytea... and DB returns it as bytea anyway. so this change just to be consistent. bytes type we support to allow configure default_data_value for cases where we want return something meaningful instead of acrablock/acrastruct from app side

G1gg1L3s
G1gg1L3s approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@G1gg1L3s G1gg1L3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Zhaars Zhaars self-requested a review April 6, 2022 10:34
Zhaars
Zhaars approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@Zhaars Zhaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lagovas. Looks good

@Lagovas Lagovas merged commit b5b1e50 into master Apr 6, 2022
@Lagovas Lagovas deleted the lagovas/convert-bytes-to-bytea branch April 6, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G1gg1L3s G1gg1L3s G1gg1L3s approved these changes

@Zhaars Zhaars Zhaars approved these changes

@iamnotacake iamnotacake Awaiting requested review from iamnotacake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lagovas @G1gg1L3s @Zhaars