Extend Keystore interface #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods GetClientIDEncryptionKey and GetZoneIDEncryptionKey that should return only the latest key that will be used to encrypt data by client / in zone. By default, it will simply request all keys and take the latest one, so no performance improvements until these methods are properly implemented in different keystores.
Use `go generate ./...` to generate newer mock interface implementations in `keystore/mocks` so they will include new keystore methods. Fix some tests where the new methods were missing as well.
…tend-keystore-interface
After recent re-generation of some files, more golint issues were introduced so had to increase allowed number, it's not related to changes done in code.
Introduce new function `getLatestSymmetricKey`, similar to `getSymmetricKeys` that will only read one key, use it in methods implementation
Lagovas
reviewed
Feb 16, 2022
Lagovas
reviewed
Feb 16, 2022
GetClientIDEncryptionKey -> GetClientIDSymmetricKey GetZoneIDEncryptionKey -> GetZoneIDSymmetricKey
…tend-keystore-interface
Extend `RecordProcessorKeyStore` and `PoisonKeyStore` with new nethod: GetPoisonSymmetricKey() ([]byte, error) and implement it in keystores v1/v2. Use this function in `Get*IDSymmetricKey` of poison keystore. Comment unused function `NewRecordProcessor` that caused compilation issues. Re-generate some mock files again.
Lagovas
reviewed
Feb 17, 2022
| // If a poison record does not exist, it is created and its sole symmetric key is returned. | ||
| func (store *KeyStore) GetPoisonSymmetricKey() ([]byte, error) { | ||
| keyFileName := getSymmetricKeyName(PoisonKeyFilename) | ||
| poisonKeyExists, err := store.fs.Exists(store.GetPrivateKeyFilePath(keyFileName)) |
There was a problem hiding this comment.
my last comment was related to this block
#496 (comment)
Lagovas
requested changes
Feb 17, 2022
| // Try getting it from cache first | ||
| key, ok := store.cache.Get(keyFileName) | ||
| if ok { | ||
| return key, nil |
There was a problem hiding this comment.
here is it's encrypted unuseful key. we should decrypt it. and add test if your tests passed it )
Lagovas
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods
GetClientIDSymmetricKeyandGetZoneIDSymmetricKeythat should return only the latest key that will be used to encrypt data by client / in zone.Implemented new methods for filesystem keystore v1 and v2 (but no special impl for poison keys).
This should cover Redis as well.
Checklist
Public API has proper documentation in the Acra documentation site or has PR on documentation repositorywith new changes
CHANGELOG.md is updated (in case of notable or breaking changes)Benchmark results are attached (if applicable)Example projects and code samples are up-to-date (in case of API changes)