Updated keymaker behaviour #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to keymaker to generate keys with empty client_id
Lagovas
reviewed
Nov 11, 2021
tests/test.py
Outdated
| subprocess.check_output( | ||
| ['./acra-keymaker', '--keystore={}'.format(KEYSTORE_VERSION), | ||
| '--keys_output_dir={}'.format(folder), | ||
| '--client_id=''', |
There was a problem hiding this comment.
what will print next code:
a = '--client_id='''
print(a)
?
I suggest to rewrite this literal to '--client_id' or "--client_id=''" to be more readable what the actual value will be used. Because now we check client_id validation, not empty value)
There was a problem hiding this comment.
Actually, this code will produce just -client_id= which is totally fine for our scenario, but in case of simply passing --client_id it wont start because you are passing param but not specified its value:)
a = '--client_id='''
print(a)
fixed integration tests
fixed after review
split vault unit tests by versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
keymakertool to be able to generate keys that are not usingclient_idwith its empty definition.client_idwill be validated only for generation of keys with requiredclient_idChecklist
with new changes