handle casted placeholders [T1075] #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixentael
approved these changes
Mar 11, 2019
vixentael
reviewed
Mar 11, 2019
| @@ -618,572 +619,521 @@ var yyExca = [...]int{ | |||
| 153, 272, | |||
| -2, 262, | |||
| -1, 248, | |||
| 111, 616, | |||
| 111, 617, | |||
There was a problem hiding this comment.
this code is fully generated, right?
There was a problem hiding this comment.
sql.go is auto-generated from sql.y via goyacc
ilammy
approved these changes
Mar 12, 2019
storojs72
reviewed
Mar 12, 2019
| @@ -1577,6 +1577,8 @@ func TestConvert(t *testing.T) { | |||
| input: "select convert('abc', json) from t", | |||
| }, { | |||
| input: "select convert('abc' using ascii) from t", | |||
| }, { | |||
| input: "select $1::integer::bytea from dual where test = $2::varchar::bytea", | |||
There was a problem hiding this comment.
$1::integer::bytea - this is valid only in postgres, right? Is it possible to cast into bytea right away?
There was a problem hiding this comment.
yes, only postgres
storojs72
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*support type cast for placeholders:
select $1::type1::type2 from table1 where column1=$2::type3::type4before placeholders were as the separate expression and worked only with placeholders without any casts.
to add cast support it needed to duplicate same logic as it was done for SQLVal with extra field for expression struct that will contain type info as bytes and extend
formatmethod. But this way has one disadvantage that we can't handle such expressions assqlvalin our censor rules and encryptor's logic.So, to handle it better, it to work with placeholders as with
sqlval's and extend rule fortypecastto support more than one type.