Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix most of golint warnings #301

Merged
merged 1 commit into from
Jan 10, 2019
Merged

fix most of golint warnings #301

merged 1 commit into from
Jan 10, 2019

Conversation

Lagovas
Copy link
Collaborator

@Lagovas Lagovas commented Jan 9, 2019

caught the moment when we all finished our work with code and renamed most of constants/identifiers according to golang conventions and reduced warnings from golint : )
left some warnings which related with package names with underscore where I am not sure that it need to be changed and some names of components

acra-censor/acra-censor_interfaces.go:36:6: type name will be used as acracensor.AcraCensorInterface by other packages, and that stutters; consider calling this Interface
cmd/acra-connector/connector-mode/connector-mode.go:21:1: don't use an underscore in package name
cmd/acra-translator/grpc_api/api_test.go:1:1: don't use an underscore in package name
cmd/acra-translator/grpc_api/decryptor.go:20:1: don't use an underscore in package name
cmd/acra-translator/http_api/decryptor.go:20:1: don't use an underscore in package name
cmd/acra-translator/http_api/decryptor_test.go:1:1: don't use an underscore in package name
cmd/acra-translator/http_api/mock_keystorage.go:17:1: don't use an underscore in package name
cmd/acra-translator/http_api/mock_poison_callback.go:17:1: don't use an underscore in package name
network/secure_session_wrapper.go:49:34: method GetPublicKeyForId should be GetPublicKeyForID
zone/utils.go:40:6: func name will be used as zone.ZoneDataToJSON by other packages, and that stutters; consider calling this DataToJSON

vixentael
vixentael requested changes Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@vixentael vixentael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! I almost feel with my skin how clean our codebase becomes 😌😌😌

.circleci/check_golint.sh Show resolved Hide resolved
decryptor/postgresql/proxy.go Show resolved Hide resolved
sqlparser/sql.go Show resolved Hide resolved
@Lagovas Lagovas merged commit 3392e9b into cossacklabs:master Jan 10, 2019
@Lagovas Lagovas deleted the lagovas/golint-fixes branch January 15, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vixentael vixentael vixentael approved these changes

@storojs72 storojs72 storojs72 approved these changes

@shadinua shadinua Awaiting requested review from shadinua

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lagovas @vixentael @storojs72