print version on start #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilammy
reviewed
Feb 21, 2019
| @@ -209,7 +209,7 @@ type Config struct { | |||
| } | |||
|
|
|||
| func main() { | |||
| log.Infof("Starting service %v [pid=%v]", ServiceName, os.Getpid()) | |||
| log.WithField("version", utils.VERSION).Infof("Starting service %v [pid=%v]", ServiceName, os.Getpid()) | |||
There was a problem hiding this comment.
Hm... Why add version as a field but keep service name and PID just a part of the log string?
There was a problem hiding this comment.
hm... I don't know what to say) legacy version vs new version)) All our components log at startup like Starting service BLABLA [pid=123] and only 3 (server/connector/translator) works as a daemon and good to log version for them. So used field to log instead raw string format
vixentael
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added logging version at start. it looks now like that: